Move primary IP count to separate metric to not affect the IPAM math #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested review from
thatmattlong and
rsagasthya
and removed request for
a team
thatmattlong
approved these changes
Sep 7, 2022
Signed-off-by: Evan Baker <[email protected]>
rbtr
force-pushed
the
fix/primary-ip-counting
branch
from
65dc987 to
3010f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker [email protected]
Reason for Change:
The NC primary IP is not an assignable IP and should not be used by CNS when calculating the IPAM pool scale math. This moves the Primary IP count to a separate metric so that it is not artificially inflating the Total IP count that CNS thinks it has available to assign.
Issue Fixed:
Requirements:
Notes: